Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/alert: can't set inventory_cache_timeout/service_cache_timeout from CLI #36104

Merged
merged 2 commits into from Jul 18, 2020

Conversation

neha-ojha
Copy link
Member

@neha-ojha neha-ojha commented Jul 14, 2020

backport tracker: https://tracker.ceph.com/issues/45228

84daea2 has been dropped since it is irrelevant for nautilus


backport of #32316
parent tracker: https://tracker.ceph.com/issues/43363

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

The option needs to be in `secs` type to enable input checking and
type casting.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 368c810)
The option setting loop in config_notify raises an exception if
smtp_host option is not configured.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit b6b6f04)
@neha-ojha neha-ojha added this to the nautilus milestone Jul 14, 2020
@neha-ojha neha-ojha added the core label Jul 14, 2020
@neha-ojha neha-ojha changed the title nautilus: mgr/cephadm: fix type of timeout options nautilus: mgr/alerts: fix type of interval option Jul 14, 2020
@neha-ojha neha-ojha changed the title nautilus: mgr/alerts: fix type of interval option nautilus: mgr/alert: can't set inventory_cache_timeout/service_cache_timeout from CLI Jul 14, 2020
@neha-ojha neha-ojha requested a review from jdurgin July 14, 2020 23:08
@smithfarm smithfarm requested a review from bk201 July 15, 2020 10:56
@neha-ojha neha-ojha added nautilus-batch-1 nautilus point releases and removed octopus-batch-1 labels Jul 16, 2020
@yuriw
Copy link
Contributor

yuriw commented Jul 16, 2020

@yuriw yuriw merged commit ebb3b88 into ceph:nautilus Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants