Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: cephfs: client: fix extra open ref decrease #36966

Merged
merged 1 commit into from Oct 5, 2020
Merged

nautilus: cephfs: client: fix extra open ref decrease #36966

merged 1 commit into from Oct 5, 2020

Conversation

Vicente-Cheng
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/46787

backport of #36233
parent tracker: https://tracker.ceph.com/issues/46664

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@lxbsz @Vicente-Cheng
client: fix extra open ref decrease
18fb3f0 
There is only one place increasing the open ref, but possibly decreased
twice.

Fixes: https://tracker.ceph.com/issues/46664
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit a7e3f54)
@Vicente-Cheng
Copy link
Contributor Author

jenkins retest this please

@batrick
Copy link
Member

batrick commented Sep 16, 2020

jenkins test make check

@batrick batrick added cephfs Ceph File System needs-qa labels Sep 16, 2020
@batrick batrick added this to the nautilus milestone Sep 16, 2020
@batrick
Copy link
Member

batrick commented Sep 16, 2020

@Vicente-Cheng please don't forget to label the backport PR. Otherwise it might not get tested.

@Vicente-Cheng
Copy link
Contributor Author

hi @batrick, thanks for your remind! I know that we need to label the backport prs to prevent that may not be tested.

Would I get permission to label backport prs? (Now I could not label any in backport prs)

@batrick
Copy link
Member

batrick commented Sep 17, 2020

hi @batrick, thanks for your remind! I know that we need to label the backport prs to prevent that may not be tested.

Would I get permission to label backport prs? (Now I could not label any in backport prs)

@jdurgin added you to the necessary Ceph project team I think. You should be able to do it now!

@Vicente-Cheng
Copy link
Contributor Author

hi @batrick, thanks for your remind! I know that we need to label the backport prs to prevent that may not be tested.
Would I get permission to label backport prs? (Now I could not label any in backport prs)

@jdurgin added you to the necessary Ceph project team I think. You should be able to do it now!

sorry @batrick, I tried and still could not label my other backport prs.
Would you please help to check it when you are free? Thanks a lot! : )

@jdurgin
Copy link
Member

jdurgin commented Sep 18, 2020

@Vicente-Cheng it looks like you need to accept the invite to the ceph org - you should have gotten an email with a link to do so

@Vicente-Cheng
Copy link
Contributor Author

@Vicente-Cheng it looks like you need to accept the invite to the ceph org - you should have gotten an email with a link to do so

@jdurgin, thanks for your tips.
Now everything looks fine, thanks for helping again!! : )

@smithfarm
Copy link
Contributor

jenkins test make check

@smithfarm smithfarm changed the title nautilus: client: fix extra open ref decrease nautilus: cephfs: client: fix extra open ref decrease Sep 23, 2020
@smithfarm smithfarm added the nautilus-batch-1 nautilus point releases label Sep 23, 2020
@yuriw
Copy link
Contributor

yuriw commented Sep 23, 2020

wip-yuri6-testing-2020-09-23-1226-nautilus

@yuriw yuriw merged commit 8dda327 into ceph:nautilus Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajarr ajarr ajarr approved these changes

@batrick batrick Awaiting requested review from batrick

Assignees
No one assigned
Labels
cephfs Ceph File System nautilus-batch-1 nautilus point releases needs-qa wip-yuri6-testing
Projects
None yet
Milestone
nautilus
7 participants
@Vicente-Cheng @batrick @jdurgin @smithfarm @yuriw @ajarr @lxbsz