New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Update datatable only when necessary #37044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for taking care of this. Just commented on the syntax used.
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
Outdated
Show resolved
Hide resolved
Fixes: https://tracker.ceph.com/issues/47359 Signed-off-by: Volker Theile <vtheile@suse.com>
9025dcb
to
149fbc5
Compare
jenkins retest this please |
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
Show resolved
Hide resolved
jenkins test dashboard |
1 similar comment
jenkins test dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jenkins test dashboard |
Fixes: https://tracker.ceph.com/issues/47359
Signed-off-by: Volker Theile vtheile@suse.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox