Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Update datatable only when necessary #37044

Merged
merged 1 commit into from Sep 14, 2020

Conversation

votdev
Copy link
Member

@votdev votdev commented Sep 8, 2020

Fixes: https://tracker.ceph.com/issues/47359

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking care of this. Just commented on the syntax used.

@votdev
Copy link
Member Author

votdev commented Sep 8, 2020

jenkins retest this please

@tspmelo tspmelo requested a review from a team September 9, 2020 08:36
@votdev
Copy link
Member Author

votdev commented Sep 10, 2020

jenkins test dashboard

1 similar comment
@votdev
Copy link
Member Author

votdev commented Sep 10, 2020

jenkins test dashboard

Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@callithea
Copy link
Member

jenkins test dashboard

@votdev votdev added skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology ready-to-merge labels Sep 14, 2020
@LenzGr LenzGr merged commit 4432903 into ceph:master Sep 14, 2020
@votdev votdev deleted the update_on_demand branch September 14, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dashboard skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
None yet
6 participants