Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard/api: move/create OSD histogram in separate endpoint #37192

Merged
merged 1 commit into from Sep 23, 2020

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Sep 16, 2020

Added a separate endpoint for osd/histogram - api/osd/{svc_id}/histogram

Fixes:https://tracker.ceph.com/issues/46898
Signed-off-by:Aashish Sharma aasharma@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

votdev
votdev previously requested changes Sep 18, 2020
src/pybind/mgr/dashboard/controllers/osd.py Outdated Show resolved Hide resolved
src/pybind/mgr/dashboard/controllers/osd.py Show resolved Hide resolved
src/pybind/mgr/dashboard/controllers/osd.py Outdated Show resolved Hide resolved
Added a separate endpoint for osd/histogram - api/osd/{svc_id}/histogram

Fixes:https://tracker.ceph.com/issues/46898
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14
Copy link
Contributor Author

jenkins test make check

@aaSharma14
Copy link
Contributor Author

jenkins test api

@LenzGr LenzGr dismissed votdev’s stale review September 22, 2020 07:19

Suggestions have been addressed, please re-review!

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good @aaSharma14 ! Thanks.

@callithea
Copy link
Member

callithea commented Sep 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants