fix mon osd failure message leaks #373

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@liewegas
Member

2 leaks, both in normal and failure cancellation paths.

liewegas added some commits Jun 22, 2013
@liewegas liewegas mon: fix leak of MOSDFailure messages
We need to discard/cancel/free the failure report messages before we
cancel a report out.  Assert in the dtor to ensure we didn't forget.

Signed-off-by: Sage Weil <sage@inktank.com>
b33c2ca
@liewegas liewegas mon: do not leak no_reply messages
I think I assumed no_reply() was releasing the references, but it is
not.  Which is better, since send_reply() doesn't either.  Fix the leaks
but dropping the message ref explicitly.

Signed-off-by: Sage Weil <sage@inktank.com>
a9b5af3
@jecluis
Member

Looks right.

@liewegas liewegas closed this Jun 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment