Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: set_choose_tries = 100 for erasure code rulesets #3824

Merged
1 commit merged into from Mar 11, 2015

Conversation

Projects
None yet
2 participants
@ghost
Copy link

commented Feb 27, 2015

It is common for people to try to map 9 OSDs out of a 9 OSDs total ceph
cluster. The default tries (50) will frequently lead to bad mappings for
this use case. Changing it to 100 makes no significant CPU performance
difference, as tested manually by running crushtool on one million
mappings.

http://tracker.ceph.com/issues/10353 Fixes: #10353

Signed-off-by: Loic Dachary ldachary@redhat.com
(cherry picked from commit 2f87ac8)

Conflicts:
src/erasure-code/lrc/ErasureCodeLrc.cc
safely ignored because the file does not exist

crush: set_choose_tries = 100 for erasure code rulesets
It is common for people to try to map 9 OSDs out of a 9 OSDs total ceph
cluster. The default tries (50) will frequently lead to bad mappings for
this use case. Changing it to 100 makes no significant CPU performance
difference, as tested manually by running crushtool on one million
mappings.

http://tracker.ceph.com/issues/10353 Fixes: #10353

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 2f87ac8)

Conflicts:
	src/erasure-code/lrc/ErasureCodeLrc.cc
        safely ignored because the file does not exist

@ghost ghost added bug fix core labels Feb 27, 2015

@ghost ghost added this to the firefly milestone Feb 27, 2015

@ghost ghost self-assigned this Feb 27, 2015

@loic-bot

This comment has been minimized.

Copy link

commented Feb 27, 2015

SUCCESS: the output of run-make-check.sh on centos-centos7 for 3db33c1 is http://paste2.org/_G9n7Up7Y

:octocat: Sent from GH.

ghost pushed a commit that referenced this pull request Mar 11, 2015

Merge pull request #3824 from dachary/wip-10353-firefly
crush: set_choose_tries = 100 for erasure code rulesets

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit f91d355 into ceph:firefly Mar 11, 2015

@ghost ghost changed the title crush: set_choose_tries = 100 for erasure code rulesets common: crush: set_choose_tries = 100 for erasure code rulesets Jul 14, 2015

@ghost ghost changed the title common: crush: set_choose_tries = 100 for erasure code rulesets crush: set_choose_tries = 100 for erasure code rulesets Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.