New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: PGMonitor: several stats output error fixes #3826

Merged
3 commits merged into from Mar 11, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Feb 27, 2015

Joao Eduardo Luis added some commits Jan 16, 2015

mon: PGMonitor: fix division by zero on stats dump
Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
(cherry picked from commit 50547dc)
mon: PGMonitor: available size 0 if no osds on pool's ruleset
get_rule_avail() may return < 0, which we were using blindly assuming it
would always return an unsigned value.  We would end up with weird
values if the ruleset had no osds.

Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
(cherry picked from commit 8be6a6a)
mon: PGMonitor: skip zeroed osd stats on get_rule_avail()
Fixes: #10257

Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
(cherry picked from commit b311e7c)

Conflicts:
	src/mon/PGMonitor.cc
        ceph::unordered_map changed the context, simple resolution

@ghost ghost added bug fix core labels Feb 27, 2015

@ghost ghost added this to the firefly milestone Feb 27, 2015

@ghost ghost assigned jecluis Feb 27, 2015

@ghost

This comment has been minimized.

ghost commented Feb 27, 2015

@jecluis does this backport look right to you ?

@loic-bot

This comment has been minimized.

loic-bot commented Feb 27, 2015

SUCCESS: the output of run-make-check.sh on centos-centos7 for 7a90d04 is http://paste2.org/_fVBFctf6

:octocat: Sent from GH.

@jecluis

This comment has been minimized.

Member

jecluis commented Mar 1, 2015

@dachary looks good!

@jecluis jecluis assigned ghost and unassigned jecluis Mar 1, 2015

@ghost ghost assigned jecluis and unassigned ghost Mar 11, 2015

ghost pushed a commit that referenced this pull request Mar 11, 2015

Merge pull request #3826 from dachary/wip-10257-firefly
mon: PGMonitor: several stats output error fixes

Reviewed-by: Joao Eduardo Luis <joao@redhat.com>

@ghost ghost merged commit be6559a into ceph:firefly Mar 11, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment