Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: fix sporadic failures in TestMigration.StressLive #38494

Merged
merged 2 commits into from Dec 11, 2020

Conversation

dillaman
Copy link

@dillaman dillaman commented Dec 8, 2020

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trociny
Copy link
Contributor

trociny commented Dec 11, 2020

@dillaman Could you please rebase after #38492 is merged?

Also, when testing this PR and #38492 #38517 I observed the librbd test getting stuck in TestInternal.PoolMetadataConfApply. The cause is not clear, most probably it is not related, and I failed to reproduce rerunning the test several times. Just FYI.

[1] http://qa-proxy.ceph.com/teuthology/trociny-2020-12-10_20:13:16-rbd-wip-mgolub-testing-distro-basic-smithi/5698848/teuthology.log

Jason Dillaman added 2 commits December 11, 2020 08:02
This initial version subsumes the original "flatten" boolean flag.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The migration operation and the copyup state machine will set
this flag when attempting to perform a deep-copy due to a
live-migration.

This flag will prevent a possible race condition between the
start of the object deep-copy when migration was enabled and
the writing portion of the deep-copy when migration might
have completed via external means.

Fixes: https://tracker.ceph.com/issues/45694
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman
Copy link
Author

rebased

dillaman pushed a commit to dillaman/ceph that referenced this pull request Dec 11, 2020
@trociny trociny merged commit cbbfd1c into ceph:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants