Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multifs: remove multifs experimental warnings #38495

Merged
merged 3 commits into from Dec 18, 2020
Merged

multifs: remove multifs experimental warnings #38495

merged 3 commits into from Dec 18, 2020

Conversation

batrick
Copy link
Member

@batrick batrick commented Dec 9, 2020

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@batrick batrick added the cephfs Ceph File System label Dec 9, 2020
@batrick
Copy link
Member Author

batrick commented Dec 9, 2020

jenkins test make check

@batrick batrick force-pushed the i22477 branch 2 times, most recently from dcbd803 to f9ae2bd Compare December 12, 2020 03:16
@batrick batrick requested review from jtlayton, vshankar, ajarr and a team December 14, 2020 15:33
jtlayton
jtlayton requested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. I have a question about the ever_enabled_multiple flag, and I think one of the paragraphs could use some clarification.

doc/cephfs/multifs.rst Outdated Show resolved Hide resolved
doc/cephfs/multifs.rst Outdated Show resolved Hide resolved
src/mds/FSMap.h Show resolved Hide resolved
@batrick
mon,mds: mark multifs stable
2683713 
Fixes: https://tracker.ceph.com/issues/22477
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
qa: update tests concerning setting of multifs
4bd9ef0 
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick batrick force-pushed the i22477 branch 2 times, most recently from c189429 to 53e417c Compare December 14, 2020 19:45
@jtlayton jtlayton self-requested a review December 14, 2020 20:14
jtlayton
jtlayton approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@batrick batrick marked this pull request as ready for review December 14, 2020 21:50
ajarr
ajarr reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ajarr ajarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc render looks good,
https://ceph--38495.org.readthedocs.build/en/38495/cephfs/multifs/

doc/cephfs/multifs.rst Outdated Show resolved Hide resolved
@batrick
doc: add documentation for new multifs feature
0376ce7 
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
vshankar
vshankar approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batrick batrick merged commit 802fd61 into ceph:master Dec 18, 2020
@batrick batrick deleted the i22477 branch December 18, 2020 21:25
@batrick
Copy link
Member Author

batrick commented Dec 18, 2020

https://pulpito.ceph.com/pdonnell-2020-12-17_23:13:08-fs-wip-pdonnell-testing-20201217.205941-distro-basic-smithi/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar approved these changes

@ajarr ajarr ajarr approved these changes

@jtlayton jtlayton jtlayton approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System core documentation mon needs-qa tests wip-pdonnell-testing
Projects
None yet
Milestone
No milestone
6 participants
@batrick @vshankar @ajarr @jtlayton @rishabh-d-dave @luis-henrix