Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: SimpleMessenger: allow RESETSESSION whenever we forget an endpoint #3915

Merged
1 commit merged into from Mar 11, 2015

Conversation

Projects
None yet
2 participants
@ghost
Copy link

commented Mar 9, 2015

In the past (e229f84) we decided to disable
reset of lossless Pipes, because lossless peers resetting caused trouble and
they can't forget about each other. But they actually can: if mark_down()
is called.

I can't figure out how else we could forget about a remote endpoint, so I think
it's okay if we tell them we reset in order to clean up state. That's desirable
so that we don't get into strange situations with out-of-whack counters.

Fixes: #10080
Backport: giant, firefly, dumpling

Signed-off-by: Greg Farnum gfarnum@redhat.com
(cherry picked from commit 8cd1fdd)

SimpleMessenger: allow RESETSESSION whenever we forget an endpoint
In the past (e229f84) we decided to disable
reset of lossless Pipes, because lossless peers resetting caused trouble and
they can't forget about each other. But they actually can: if mark_down()
is called.

I can't figure out how else we could forget about a remote endpoint, so I think
it's okay if we tell them we reset in order to clean up state. That's desirable
so that we don't get into strange situations with out-of-whack counters.

Fixes: #10080
Backport: giant, firefly, dumpling

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit 8cd1fdd)

@ghost ghost added bug fix core labels Mar 9, 2015

@ghost ghost added this to the firefly milestone Mar 9, 2015

@ghost ghost assigned gregsfortytwo Mar 9, 2015

@gregsfortytwo

This comment has been minimized.

Copy link
Member

commented Mar 9, 2015

This backport looks good.

@gregsfortytwo gregsfortytwo assigned ghost and unassigned gregsfortytwo Mar 9, 2015

@loic-bot

This comment has been minimized.

Copy link

commented Mar 9, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for ff44c81 is http://paste2.org/U60Wna0k

:octocat: Sent from GH.

ghost pushed a commit that referenced this pull request Mar 11, 2015

Merge pull request #3915 from dachary/wip-10080-firefly
SimpleMessenger: allow RESETSESSION whenever we forget an endpoint

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

@ghost ghost merged commit b7e3614 into ceph:firefly Mar 11, 2015

@ghost ghost changed the title SimpleMessenger: allow RESETSESSION whenever we forget an endpoint common: SimpleMessenger: allow RESETSESSION whenever we forget an endpoint Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.