New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: Translate operation flags from C APIs #3930

Merged
1 commit merged into from Mar 16, 2015

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Mar 10, 2015

http://tracker.ceph.com/issues/10497

The operation flags in the public C API are a distinct enum
and need to be translated to Ceph OSD flags, like as happens in
the C++ API. It seems like the C enum and the C++ enum consciously
use the same values, so I reused the C++ translation function.

Signed-off-by: Matthew Richards mattjrichards@gmail.com
(cherry picked from commit 49d114f)

Conflicts:
src/librados/librados.cc
comes from lttng tracepoints introduced after firefly

librados: Translate operation flags from C APIs
The operation flags in the public C API are a distinct enum
and need to be translated to Ceph OSD flags, like as happens in
the C++ API. It seems like the C enum and the C++ enum consciously
use the same values, so I reused the C++ translation function.

Signed-off-by: Matthew Richards <mattjrichards@gmail.com>
(cherry picked from commit 49d114f)

Conflicts:
	src/librados/librados.cc
        comes from lttng tracepoints introduced after firefly

@ghost ghost added bug fix core labels Mar 10, 2015

@ghost ghost added this to the firefly milestone Mar 10, 2015

@ghost ghost self-assigned this Mar 10, 2015

@jdurgin

This comment has been minimized.

Member

jdurgin commented Mar 10, 2015

👍

@loic-bot

This comment has been minimized.

loic-bot commented Mar 10, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for afb70d2 is http://paste2.org/6KZUm5XM

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3930 from dachary/wip-10497-firefly
librados: Translate operation flags from C APIs

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@ghost ghost merged commit fa518ff into ceph:firefly Mar 16, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment