New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: requeue blocked op before flush it was blocked on #3931

Merged
1 commit merged into from Mar 16, 2015

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Mar 10, 2015

If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.

This was observed on this firefly run:

ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 11bdfb4)

osd: requeue blocked op before flush it was blocked on
If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.

This was observed on this firefly run:

  ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675

Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 11bdfb4)

@ghost ghost added bug fix core labels Mar 10, 2015

@ghost ghost added this to the firefly milestone Mar 10, 2015

@ghost ghost self-assigned this Mar 10, 2015

@loic-bot

This comment has been minimized.

loic-bot commented Mar 10, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 2ad509d is http://paste2.org/1VMBFjW4

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3931 from dachary/wip-10512-firefly
osd: requeue blocked op before flush it was blocked on

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit f4e76c3 into ceph:firefly Mar 16, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment