New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: DBObjectMap: lock header_lock on sync() #3948

Merged
1 commit merged into from Mar 16, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Mar 11, 2015

http://tracker.ceph.com/issues/9891

Otherwise, we can race with another thread updating state.seq
resulting in the old, smaller value getting persisted. If there
is a crash at that time, we will reuse a sequence number, resulting
in an inconsistent node tree and bug #9891.

Fixes: 9891
Backport: giant, firefly, dumpling
Signed-off-by: Samuel Just sjust@redhat.com
(cherry picked from commit 2b63dd2)

Conflicts:
src/os/DBObjectMap.cc
because we have state.v = 1; instead of state.v = 2;

DBObjectMap: lock header_lock on sync()
Otherwise, we can race with another thread updating state.seq
resulting in the old, smaller value getting persisted.  If there
is a crash at that time, we will reuse a sequence number, resulting
in an inconsistent node tree and bug #9891.

Fixes: 9891
Backport: giant, firefly, dumpling
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 2b63dd2)

Conflicts:
	src/os/DBObjectMap.cc
        because we have state.v = 1; instead of state.v = 2;

@ghost ghost added bug fix core labels Mar 11, 2015

@ghost ghost added this to the firefly milestone Mar 11, 2015

@ghost ghost self-assigned this Mar 11, 2015

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 8c4f35a is http://paste2.org/EE1CNkbN

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3948 from dachary/wip-9891-firefly
DBObjectMap: lock header_lock on sync()

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit 31d99d2 into ceph:firefly Mar 16, 2015

@ghost ghost changed the title from DBObjectMap: lock header_lock on sync() to osd: DBObjectMap: lock header_lock on sync() Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment