New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: get the currently atime of the object in cache pool for eviction #3950

Merged
2 commits merged into from Mar 16, 2015

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Mar 11, 2015

http://tracker.ceph.com/issues/9985

Because if there are mutiple atime in agent_state for the same object, we should use the recently one.

Signed-off-by: Xinze Chi xmdxcxz@gmail.com
(cherry picked from commit 1fef4c3)

Get the currently atime of the object in cache pool for eviction
Because if there are mutiple atime in agent_state for the same object, we should use the recently one.

Signed-off-by: Xinze Chi <xmdxcxz@gmail.com>
(cherry picked from commit 1fef4c3)

@ghost ghost added bug fix core labels Mar 11, 2015

@ghost ghost self-assigned this Mar 11, 2015

@ghost ghost added this to the firefly milestone Mar 11, 2015

@XinzeChi

This comment has been minimized.

Member

XinzeChi commented Mar 11, 2015

@dachary , backport #2856 too?

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

FAIL: the output of run-make-check.sh on centos-7 for c9e6b15 is http://paste2.org/C8XAFJmH

:octocat: Sent from GH.

@XinzeChi

This comment has been minimized.

Member

XinzeChi commented Mar 11, 2015

There is bug in this patch. We should use reverse_iterator instead of iterator.

osd/ReplicatedPG: fix compile error
From 1fef4c3.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 4a9ad7d)
@ghost

This comment has been minimized.

ghost commented Mar 11, 2015

@XinzeChi added the fix a746f7e thanks !

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 9d0eeed is http://paste2.org/Ea2Hk0Zk

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3950 from dachary/wip-9985-firefly
Get the currently atime of the object in cache pool for eviction

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xinze Chi <xmdxcxz@gmail.com>

@ghost ghost merged commit 2b8e476 into ceph:firefly Mar 16, 2015

@ghost ghost changed the title from Get the currently atime of the object in cache pool for eviction to osd: get the currently atime of the object in cache pool for eviction Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment