New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: ObjectStore: Don't use largest_data_off to calc data_align. #3954

Merged
1 commit merged into from Mar 16, 2015

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Mar 11, 2015

http://tracker.ceph.com/issues/10014

If largest_data_off % CEPH_PAGE_SIZE != 0, the get_data_aligment return
a erro value. This make the FileJouranl::align_bl to memcopy much data.

Tested-by: Sage Weil sage@redhat.com
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com
(cherry picked from commit a1aa70f)

ObjectStore: Don't use largest_data_off to calc data_align.
If largest_data_off % CEPH_PAGE_SIZE != 0, the get_data_aligment return
a erro value. This make the FileJouranl::align_bl to memcopy much data.

Tested-by: Sage Weil <sage@redhat.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
(cherry picked from commit a1aa70f)

@ghost ghost added cleanup core labels Mar 11, 2015

@ghost ghost self-assigned this Mar 11, 2015

@ghost ghost added this to the firefly milestone Mar 11, 2015

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 8fd3ea7 is http://paste2.org/D5GfmwDb

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3954 from dachary/wip-10014-firefly
ObjectStore: Don't use largest_data_off to calc data_align.

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit ccebb5f into ceph:firefly Mar 16, 2015

@ghost ghost changed the title from ObjectStore: Don't use largest_data_off to calc data_align. to osd: ObjectStore: Don't use largest_data_off to calc data_align. Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment