New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: PG: always clear_primary_state #3955

Merged
2 commits merged into from Mar 16, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Mar 11, 2015

PG: always clear_primary_state when leaving Primary
Otherwise, entries from the log collection process might leak into the next
epoch, where we might end up choosing a different authoritative log.  In this
case, it resulted in us not rolling back to log entries on one of the replicas
prior to trying to recover from an affected object due to the peer_missing not
being cleared.

Fixes: #10059
Backport: giant, firefly, dumpling
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit c87bde6)

@ghost ghost added bug fix core labels Mar 11, 2015

@ghost ghost added this to the firefly milestone Mar 11, 2015

@ghost ghost self-assigned this Mar 11, 2015

PG: always clear_primary_state on new interval, but only clear pg tem…
…p if not primary

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit f692bfe)

@ghost ghost changed the title from PG: always clear_primary_state when leaving Primary to PG: always clear_primary_state Mar 11, 2015

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 51bb891 is http://paste2.org/mJFvb9Wy

:octocat: Sent from GH.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Mar 16, 2015

lgtm

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3955 from dachary/wip-10059-firefly
PG: always clear_primary_state

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit ac9980e into ceph:firefly Mar 16, 2015

@ghost ghost changed the title from PG: always clear_primary_state to osd: PG: always clear_primary_state Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment