New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fail s3 POST auth if keystone not configured #3966

Merged
1 commit merged into from Mar 16, 2015

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Mar 11, 2015

Fixes: #10698
This fixes issue introduced in 8b3dfc9,
where if user does not exist, we try keystone authentication. However,
if keystone is not configured we justt fall through without failing.
This would have failed later on due to bucket permissions, unless bucket
had a public write permissions.

Backports: Firefly
Reported-by: Valery Tschopp valery.tschopp@switch.ch
Signed-off-by: Yehuda Sadeh yehuda@redhat.com

Conflicts:
src/rgw/rgw_rest_s3.cc

rgw: fail s3 POST auth if keystone not configured
Fixes: #10698
This fixes issue introduced in 8b3dfc9,
where if user does not exist, we try keystone authentication. However,
if keystone is not configured we justt fall through without failing.
This would have failed later on due to bucket permissions, unless bucket
had a public write permissions.

Backports: Firefly
Reported-by: Valery Tschopp <valery.tschopp@switch.ch>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Conflicts:
	src/rgw/rgw_rest_s3.cc

@ghost ghost added bug fix rgw labels Mar 11, 2015

@ghost ghost added this to the firefly milestone Mar 11, 2015

@ghost ghost self-assigned this Mar 11, 2015

@loic-bot

This comment has been minimized.

loic-bot commented Mar 11, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 1b36f1d is http://paste2.org/m6BXhWnb

:octocat: Sent from GH.

ghost pushed a commit that referenced this pull request Mar 16, 2015

Merge pull request #3966 from theanalyst/wip-10698-backport
rgw: fail s3 POST auth if keystone not configured

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

@ghost ghost merged commit 493d285 into ceph:firefly Mar 16, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment