Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Improve descriptions in some parts of the dashboard #40397

Merged
merged 1 commit into from Apr 1, 2021
Merged

mgr/dashboard: Improve descriptions in some parts of the dashboard #40397

merged 1 commit into from Apr 1, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Mar 25, 2021 •
edited

Improves the description in some parts of the dashboard code.

restoretrash
movetotrash
purge
role_description

Fixes: https://tracker.ceph.com/issues/49829
Fixes: https://tracker.ceph.com/issues/49969
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 added this to In progress in Dashboard via automation Mar 25, 2021
@nizamial09 nizamial09 requested a review from a team as a code owner March 25, 2021 08:11
@nizamial09 nizamial09 requested review from callithea and aaSharma14 and removed request for a team March 25, 2021 08:11
avanthakkar
avanthakkar approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Dashboard automation moved this from In progress to Reviewer approved Mar 26, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Mar 31, 2021
Dashboard automation moved this from Ready-to-merge to Reviewer approved Mar 31, 2021
@nizamial09
mgr/dashboard: Improve descriptions in some parts of the dashboard
82235fd 
Improves the description in some parts of the dashboard code.

Fixes: https://tracker.ceph.com/issues/49829
Fixes: https://tracker.ceph.com/issues/49969
Signed-off-by: Nizamudeen A <nia@redhat.com>
callithea
callithea approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@callithea callithea moved this from Reviewer approved to needs-qa in Dashboard Apr 1, 2021
@nizamial09
Copy link
Member Author

jenkins test dashboard

@callithea callithea moved this from needs-qa to Ready-to-merge in Dashboard Apr 1, 2021
@alfonsomthd alfonsomthd merged commit a7fce57 into ceph:master Apr 1, 2021
Dashboard automation moved this from Ready-to-merge to Done Apr 1, 2021
This was referenced Apr 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@callithea callithea callithea approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@epuertat epuertat Awaiting requested review from epuertat

Assignees
No one assigned
Labels
cleanup dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@nizamial09 @alfonsomthd @avanthakkar @callithea @aaSharma14