Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: modernize the AM_INIT_AUTOMAKE for ffsb #40842

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Apr 14, 2021

The form of AM_INIT_AUTOMAKE(PACKAGE, VERSION, [NO-DEFINE]) has been deprecated,
we need to modernize it in new form and more detail please see
https://www.gnu.org/software/automake/manual/automake.html

Fixes: https://tracker.ceph.com/issues/48365
Signed-off-by: Xiubo Li xiubli@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the tests label Apr 14, 2021
@lxbsz lxbsz requested a review from a team April 14, 2021 03:53
@lxbsz lxbsz added the cephfs Ceph File System label Apr 14, 2021
@tchaikov
Copy link
Contributor

jenkins test api

tar jxvf ffsb.tar.bz2
cd ffsb-6.0-rc2
patch -p1 < $mydir/ffsb.patch
git clone https://github.com/ceph/ffsb.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be hosted on ceph.com. @djgalloway can you mirror this please?

Copy link
Contributor

@tchaikov tchaikov Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lxbsz @batrick could create a release first to ease the mirroring, which just needs to mirror the released dist tarball.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can just use the --depth 1 for the clone command instead ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ceph/ffsb/releases/tag/ceph_v1.0

How about that?

@lxbsz we try not to swarm github with our qa jobs so it's better to mirror a tarball.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the .tar.gz would suffice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batrick
I suppose we will download the tarball, with this do you mean git clone git://git.ceph.com/ffsb.git ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think you can try --depth 1 too if that helps matters but there aren't many commits to begin with.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will update this PR. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. thanks.

@lxbsz lxbsz force-pushed the ffsb11 branch 2 times, most recently from 8cf3f25 to 7a5e6bc Compare April 22, 2021 06:40
@lxbsz lxbsz requested review from batrick and tchaikov April 22, 2021 06:41
qa/workunits/suites/ffsb.sh Show resolved Hide resolved
Have add a ffsb repo under git://git.ceph.com/ to tracker the change
histories. And in that repo we have modernize the form of AM_INIT_AUTOMAKE.

Fixes: https://tracker.ceph.com/issues/48365
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented May 11, 2021

batrick added a commit to batrick/ceph that referenced this pull request May 14, 2021
* refs/pull/40842/head:
	qa: update the ffsb.sh to clone it from git://git.ceph.com/ffsb.git
@batrick
Copy link
Member

batrick commented May 18, 2021

https://tracker.ceph.com/projects/cephfs/wiki/Master#2021-May-11

@batrick batrick merged commit 80855c3 into ceph:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants