New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: modernize the AM_INIT_AUTOMAKE for ffsb #40842
Conversation
jenkins test api |
qa/workunits/suites/ffsb.sh
Outdated
tar jxvf ffsb.tar.bz2 | ||
cd ffsb-6.0-rc2 | ||
patch -p1 < $mydir/ffsb.patch | ||
git clone https://github.com/ceph/ffsb.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be hosted on ceph.com. @djgalloway can you mirror this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can just use the --depth 1
for the clone command instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ceph/ffsb/releases/tag/ceph_v1.0
How about that?
@lxbsz we try not to swarm github with our qa jobs so it's better to mirror a tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the .tar.gz would suffice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@batrick
I suppose we will download the tarball, with this do you mean git clone git://git.ceph.com/ffsb.git
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think you can try --depth 1
too if that helps matters but there aren't many commits to begin with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will update this PR. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. thanks.
8cf3f25
to
7a5e6bc
Compare
Have add a ffsb repo under git://git.ceph.com/ to tracker the change histories. And in that repo we have modernize the form of AM_INIT_AUTOMAKE. Fixes: https://tracker.ceph.com/issues/48365 Signed-off-by: Xiubo Li <xiubli@redhat.com>
The ffsb workunit test in tuethology: |
* refs/pull/40842/head: qa: update the ffsb.sh to clone it from git://git.ceph.com/ffsb.git
The form of AM_INIT_AUTOMAKE(PACKAGE, VERSION, [NO-DEFINE]) has been deprecated,
we need to modernize it in new form and more detail please see
https://www.gnu.org/software/automake/manual/automake.html
Fixes: https://tracker.ceph.com/issues/48365
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox