Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcephfs, cephfs-mirror: configurable mount timeout #40885

Merged
merged 5 commits into from May 18, 2021

Conversation

vshankar
Copy link
Contributor

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@vshankar vshankar added the cephfs Ceph File System label Apr 16, 2021
@vshankar vshankar changed the title libcephfs, cephfs-mirorr: configurable mount timeout libcephfs, cephfs-mirror: configurable mount timeout Apr 16, 2021
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a note in the docs.

otherwise lgtm

src/common/options/cephfs-mirror.yaml.in Outdated Show resolved Hide resolved
src/common/options/cephfs-mirror.yaml.in Outdated Show resolved Hide resolved
src/common/options/cephfs-mirror.yaml.in Show resolved Hide resolved
@vshankar vshankar force-pushed the wip-50035 branch 2 times, most recently from 62bba73 to 7c1c780 Compare April 19, 2021 10:14
@vshankar vshankar force-pushed the wip-50035 branch 2 times, most recently from 718d08b to d72b21c Compare April 20, 2021 01:53
@vshankar
Copy link
Contributor Author

jenkins test docs

@batrick
Copy link
Member

batrick commented Apr 20, 2021

Looks good after adopting @tchaikov 's suggestion

@vshankar
Copy link
Contributor Author

fixed and updated

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; needs rebased

@github-actions
Copy link

github-actions bot commented May 4, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@batrick
Copy link
Member

batrick commented May 4, 2021

...and rebased again

Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Fixes: http://tracker.ceph.com/issues/50035
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
Copy link
Contributor Author

vshankar commented May 5, 2021

@batrick rebased and updated

vshankar added a commit to vshankar/ceph that referenced this pull request May 5, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
Copy link
Contributor Author

@batrick ping?

@batrick
Copy link
Member

batrick commented May 14, 2021

@vshankar it needs run through QA. I should be doing a new run today or tomorrow.

@batrick
Copy link
Member

batrick commented May 18, 2021

@batrick batrick merged commit d59f2fb into ceph:master May 18, 2021
vshankar added a commit to vshankar/ceph that referenced this pull request May 21, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 0676409)
vshankar added a commit to vshankar/ceph that referenced this pull request May 23, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 0676409)
nizamial09 pushed a commit to rhcs-dashboard/ceph that referenced this pull request May 24, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
vshankar added a commit to vshankar/ceph that referenced this pull request May 28, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 0676409)
nizamial09 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Jun 11, 2021
Without this a traceback is seen in mgr logs. Also, this solves
one part of the issue. The other half (failing tests) will be
resolved by PR ceph#40885.

Resolves: rhbz#1956620

Fixes: http://tracker.ceph.com/issues/50224
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 0676409)
(cherry picked from commit 334b1dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants