rgw: remove quota soft threshold #41495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofriedma
requested changes
May 26, 2021
src/rgw/rgw_quota.cc
Outdated
| @@ -196,7 +165,9 @@ void RGWQuotaCache<T>::set_stats(const rgw_user& user, const rgw_bucket& bucket, | |||
| } | |||
|
|
|||
| template<class T> | |||
| int RGWQuotaCache<T>::get_stats(const rgw_user& user, const rgw_bucket& bucket, RGWStorageStats& stats, RGWQuotaInfo& quota, optional_yield y, const DoutPrefixProvider *dpp) { | |||
| int | |||
There was a problem hiding this comment.
I think you added new line by mistake, other than that LGTM
There was a problem hiding this comment.
Can you please squash the commits into a single commit?
Remove quota soft threshold, which causes expensive checks for sharded buckets Fixes: 14eabd4 Signed-off-by: Zulai Wang <wangzl31@outlook.com>
pleiadesian
force-pushed
the
patch-quota-cache
branch
from
dddec57
to
32a3970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this thread in dev@ceph.io, the quota soft threshold is not reasonable anymore after dynamic resharding was introduced, which causes expensive checks for sharded buckets. This pull request reverts the 14eabd4 commit to remove the quota soft threshold.
Fixes: 14eabd4
https://tracker.ceph.com/issues/50975
Signed-off-by: Zulai Wang wangzl31@outlook.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox