ceph-volume: fix batch report and respect ceph.conf config values #41506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using --block-db-size, the % of device calculation is incorrect and always reads 100%. Resolves: RHBZ#1946478 Fixes: https://tracker.ceph.com/issues/50957 Signed-off-by: Andrew Schoen <aschoen@redhat.com>
If --block-db-size is not given args.block_db_size is set to None, so we should check for it's value in ceph.conf Resolves: RHBZ#1962744 Fixes: https://tracker.ceph.com/issues/50958 Signed-off-by: Andrew Schoen <aschoen@redhat.com>
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
guits
approved these changes
May 25, 2021
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small fixes for
ceph-volume lvm batch. Respect the value ofbluestore_block_db_sizein ceph.conf and fixthe value of
% of deviceinceph-volume lvm batch --report.https://tracker.ceph.com/issues/50957
https://tracker.ceph.com/issues/50958