New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: FAILED assert(soid < scrubber.start || soid >= scrubber.end) #4185

Merged
1 commit merged into from Apr 29, 2015

Conversation

Projects
None yet
2 participants
@ldachary
Contributor

ldachary commented Mar 25, 2015

ReplicatedPG::promote_object: check scrubber and block if necessary
Otherwise, we might attempt to promote into an in-progress scrub
interval causing 11156.  I would have added a return value to
promote_object(), but could not find an existing user which
cared to distinguish the cases, even with a null op passed.
All existing users are in maybe_handle_cache.  The ones which
pass a null op are for promoting the object in parallel
with a proxy -- a case where not actually performing the promote
does not really matter.

Fixes: #11156
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 65bb4df)

@ldachary ldachary self-assigned this Mar 25, 2015

@ldachary ldachary added this to the firefly milestone Mar 25, 2015

@ghost ghost assigned ghost and unassigned ldachary Apr 2, 2015

@ghost

This comment has been minimized.

ghost commented Apr 27, 2015

@athanatos it passed the rados suite (see http://tracker.ceph.com/issues/11090#rados for details), does it look ready to merge ?

@athanatos

This comment has been minimized.

Contributor

athanatos commented Apr 29, 2015

Looks fine to me.

ghost pushed a commit that referenced this pull request Apr 29, 2015

Loic Dachary
Merge pull request #4185 from ldachary/wip-11156-firefly
FAILED assert(soid < scrubber.start || soid >= scrubber.end)

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit e980e00 into ceph:firefly Apr 29, 2015

@ghost ghost changed the title from FAILED assert(soid < scrubber.start || soid >= scrubber.end) to osd: FAILED assert(soid < scrubber.start || soid >= scrubber.end) Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment