Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/telemetry: add new 'perf' channel that shares aggregated perf counter metrics of a cluster #42074

Merged
merged 13 commits into from Jul 19, 2021
Merged

mgr/telemetry: add new 'perf' channel that shares aggregated perf counter metrics of a cluster #42074

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b5005da
mgr/telemetry: added a new channel for perf counters
ljflores Jun 28, 2021
62276e6
mgr/telemetry: incremented content revision and added a new realease …
ljflores Jun 28, 2021
bf68855
mgr/telemetry: reformat code for better readability
ljflores Jun 30, 2021
04ff1f8
mgr/telemetry: turn perf channel off by default and decrement revisio…
ljflores Jul 1, 2021
0072e2a
qa/tasks/mgr/dashboard: add perf channel to qa tests
ljflores Jul 1, 2021
d843f6b
mgr/dashboard/frontend/.../telemetry: update telemetry html and specs…
ljflores Jul 5, 2021
1629dc9
mgr/telemetry: add type annotation in gather_perf_counters()
ljflores Jul 5, 2021
78fe1a0
mgr/dashboard/frontend/.../telemetry: update telemetry frontend files…
ljflores Jul 6, 2021
702fbdb
mgr/telemetry: add underscore to perf_counters for consistency
ljflores Jul 8, 2021
4583cf3
mgr/telemetry: update gather_perf_counters() to be more accurate
ljflores Jul 9, 2021
9e07175
common: fix missing name in PriorityCache perf counters
ljflores Jul 12, 2021
cdbd4af
mgr/telemetry: add debug log for potential empty keys and combine uni…
ljflores Jul 12, 2021
1290026
mgr/telemetry: remove unnecessary parens
ljflores Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
common: fix missing name in PriorityCache perf counters 
There was a problem with PriorityCache perf counters, where part of the name was missing (i.e. "mon.a.cache_bytes" instead of "mon.a.prioritycache.cache_bytes"). The problem was happening because a 'this' pointer was missing in the original implementation.

Signed-off-by: Laura Flores <lflores@redhat.com>
  • Loading branch information
@ljflores
ljflores committed Jul 12, 2021
commit 9e07175b3c9a5c69b8694bc05e0baa26a351582d
3 changes: 1 addition & 2 deletions src/common/PriorityCache.cc
View file
Open in desktop
Expand Up @@ -73,8 +73,7 @@ namespace PriorityCache
reserve_extra(reserve_extra),
name(name.empty() ? "prioritycache" : name)
{
PerfCountersBuilder b(cct, name,
MallocStats::M_FIRST, MallocStats::M_LAST);
PerfCountersBuilder b(cct, this->name, MallocStats::M_FIRST, MallocStats::M_LAST);

b.add_u64(MallocStats::M_TARGET_BYTES, "target_bytes",
"target process memory usage in bytes", "t",
Expand Down