[POC] mgr/cephadm: Use Dashboard's credtials for grafana.ini #42245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids any additional persistent state. Fixes: https://tracker.ceph.com/issues/48291 Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
sebastian-philipp
changed the title
epuertat
reviewed
Jul 9, 2021
Comment on lines
+59
to
+64
| user = self.mgr.check_mon_command({ | ||
| 'prefix': 'dashboard get-grafana-api-username' | ||
| }).stdout | ||
| password = self.mgr.check_mon_command({ | ||
| 'prefix': 'dashboard get-grafana-api-password' | ||
| }).stdout |
There was a problem hiding this comment.
Let me check if we can drop the Grafana credentials: they were needed before cephadm, but given the Grafana dashboards are now 'injected' during container build, perhaps we can avoid this.
There was a problem hiding this comment.
that would be even better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids any additional persistent state.
Fixes: https://tracker.ceph.com/issues/48291
Signed-off-by: Sebastian Wagner sewagner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox