mgr/dashboard: remove usage of 'rgw_frontend_ssl_key'

[avanthakkar]

Fixes: https://tracker.ceph.com/issues/51643
Signed-off-by: Avan Thakkar athakkar@redhat.com

Removing the usage of rgw_frontend_ssl_key from the rgw service form.

Before:

After:

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[nizamial09]

LGTM! apart from one small question. Thanks @avanthakkar (probably a unit test to make sure its not showing for type rgws)

[avanthakkar]

LGTM! apart from one small question. Thanks @avanthakkar (probably a unit test to make sure its not showing for type rgws)

But we don't pass the ssl_key itself so Idk what to test here. It's just the visual difference you will see as I have attached the screenshot in PR description.

[nizamial09]

what to test here

@avanthakkar sorry i wasnt being clear, I was actually asking to test whether the field is present or not. Something like this in the rgw test area of the service component.

      it('should not show private key field', () => {
        formHelper.setValue('ssl', true);
        fixture.detectChanges();
        const ssl_key = fixture.debugElement.query(By.css('#ssl_key'));
        expect(ssl_key).toBeNull();
      })

[avanthakkar]

what to test here

@avanthakkar sorry i wasnt being clear, I was actually asking to test whether the field is present or not. Something like this in the rgw test area of the service component.

      it('should not show private key field', () => {
        formHelper.setValue('ssl', true);
        fixture.detectChanges();
        const ssl_key = fixture.debugElement.query(By.css('#ssl_key'));
        expect(ssl_key).toBeNull();
      })

Yes you're right. Thanks @nizamial09 , updated the changes.

[epuertat]

LGTM Thanks @avanthakkar !

[epuertat]

Shouldn't we somehow indicate the user that they're expected to submit a concatenated certificate + key (.PEM-like format)?