Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: rectify support for GET on Swift's account with "limit" parameter == 0 #4257

Merged
merged 2 commits into from Apr 21, 2015

Conversation

@rzarzynski
Copy link
Contributor

commented Apr 2, 2015

No description provided.

@@ -293,7 +293,7 @@ static int cls_user_list_buckets(cls_method_context_t hctx, bufferlist *in, buff

#define MAX_ENTRIES 1000
size_t max_entries = op.max_entries;
if (!max_entries || max_entries > MAX_ENTRIES)
if (max_entries > MAX_ENTRIES)

This comment has been minimized.

Copy link
@rzarzynski

rzarzynski Apr 2, 2015

Author Contributor

The same brackets style across the whole function - leaving as is.

@loic-bot

This comment has been minimized.

Copy link

commented Apr 2, 2015

SUCCESS: the output of run-make-check.sh on centos-7 for 3a15479 is http://paste2.org/3B75tYfH

:octocat: Sent from GH.

@ghost ghost added bug fix rgw labels Apr 2, 2015

@rzarzynski rzarzynski force-pushed the rzarzynski:wip-10683 branch from b8ee012 to ee00325 Apr 7, 2015

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2015

@yehudasa switched to strict_strtol().
Old branch: master...rzarzynski:wip-10683-old-1.

@rzarzynski rzarzynski force-pushed the rzarzynski:wip-10683 branch from ee00325 to 68bfcbb Apr 16, 2015

@rzarzynski rzarzynski changed the title rgw: rectify support for GET on Swift's container with "limit" parameter == 0 rgw: rectify support for GET on Swift's account with "limit" parameter == 0 Apr 16, 2015

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2015

@yehudasa reworked according to your suggestion. Changed title of PR too - sorry for the thinko.

@rzarzynski rzarzynski force-pushed the rzarzynski:wip-10683 branch from 68bfcbb to 75145b9 Apr 17, 2015

rzarzynski added 2 commits Mar 30, 2015
rgw: rectify support for GET on Swift's account with limit == 0.
Fixes: #10683
Backport: hammer
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rgw: make rgw_read_user_buckets() backward compatible.
Fixes: #10683
Backport: hammer
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

@rzarzynski rzarzynski force-pushed the rzarzynski:wip-10683 branch from 75145b9 to 7dd54fa Apr 20, 2015

@rzarzynski

This comment has been minimized.

Copy link
Owner Author

commented on src/rgw/rgw_rest_swift.cc in f7b92f9 Apr 20, 2015

@yehudasa switched here from ERR_PRECONDITION_FAILED to EINVAL.

yehudasa added a commit that referenced this pull request Apr 21, 2015
Merge pull request #4257 from rzarzynski/wip-10683
rgw: rectify support for GET on Swift's account with "limit" parameter == 0

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

@yehudasa yehudasa merged commit d9bf04f into ceph:master Apr 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.