pacific: msg: active_connections regression #42936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is helpful to set this to 1 for tests. Signed-off-by: Sage Weil <sage@newdream.net> (cherry picked from commit 8129d6b) Conflicts: src/common/options/global.yaml.in
We have to reap connections promptly for this test to work. This test was broken indirectly by d51d80b, which moved the counter decrement to reap time instead of mark_down/stop time. The reaping is asynchronous, so allow for a delay in the count change. Fixes: https://tracker.ceph.com/issues/50622 Signed-off-by: Sage Weil <sage@newdream.net> (cherry picked from commit c8c5071)
|
@yuriw this needs rados testing. The PR makes changes to the core. So can you run https://pulpito.ceph.com/?branch=wip-yuri8-testing-2021-08-26-1210-pacific through rados testing? The related FS test passed, https://pulpito.ceph.com/yuriw-2021-08-25_21:49:08-fs-wip-yuri5-testing-2021-08-25-1246-pacific-distro-basic-smithi/6359302/ |
ajarr
approved these changes
Sep 1, 2021
ajarr
reviewed
Sep 1, 2021
There was a problem hiding this comment.
@neha-ojha has approved the rados run here, https://trello.com/c/2djzuDQp/1324-wip-yuri8-testing-2021-08-30-0930-pacific-old-wip-yuri8-testing-2021-08-26-1210-pacific
the rados run is here, https://pulpito.ceph.com/?branch=wip-yuri8-testing-2021-08-30-0930-pacific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/51198