New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pacific: pybind/mgr: Fix IPv6 url generation #42990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 29883d6)
Fixes: https://tracker.ceph.com/issues/52117 Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit e367796)
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 0b8701b)
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 9809159)
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 3d96f79)
sebastian-philipp
suggested changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add #42886
Fixes ``` ====================================================================== ERROR: test_standby (tasks.mgr.test_prometheus.TestPrometheus) ---------------------------------------------------------------------- urllib3.exceptions.LocationParseError: Failed to parse: http://172.21.15.71:7789metrics ``` Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 45361ea)
sebastian-philipp
approved these changes
Aug 31, 2021
avanthakkar
approved these changes
Aug 31, 2021
pereman2
approved these changes
Sep 1, 2021
|
jenkins test dashboard |
|
jenkins test dashboard |
1 similar comment
|
jenkins test dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: no-conflicts
Backport without conflicts
cephadm
dashboard
mgr
needs-qa
pybind
wip-yuri6-testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52325
backport of #42793 and #42886
parent tracker: https://tracker.ceph.com/issues/52117
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh