cephadm: fix osd size reported in 'orch ls' #43253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you think we could build a test for this? |
This comment has been minimized.
This comment has been minimized.
do we have a unit test for this? |
guits
force-pushed
the
fix_orch_ls_osd
branch
from
e6757ef
to
2507723
Compare
guits
commented
Sep 29, 2021
|
jenkins test make check arm64 |
The current code enforces ('running osds' + 1), see [1].
Let's simply print the number of running osds instead of a
meaningless calculation.
[1] ceph@1c0a0a6#diff-4f2fb7d330e74b64ac41457b7c7a723cd78db86433e0b0c398874531e5a7e39eR1852-R1859
Fixes: https://tracker.ceph.com/issues/50928
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
fix_orch_ls_osd
branch
from
2507723
to
d049b1e
Compare
|
jenkins test signed |
1 similar comment
|
jenkins test signed |
This adds a unittest in order to cover the output of 'orch ls' command and check the reporting about the running osd number is displayed as expected. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> Co-Authored-by: Sebastian Wagner <sewagner@redhat.com>
guits
force-pushed
the
fix_orch_ls_osd
branch
from
d049b1e
to
1d848dc
Compare
sebastian-philipp
approved these changes
Sep 29, 2021
|
jenkins test dashboard cephadm |
|
jenkins test signed |
1 similar comment
|
jenkins test signed |
|
jenkins test dashboard cephadm |
|
looks good (except for the Agent issue) |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code enforces ('running osds' + 1), see [1].
Let's simply print the number of running osds instead of a
meaningless calculation.
[1] 1c0a0a6#diff-4f2fb7d330e74b64ac41457b7c7a723cd78db86433e0b0c398874531e5a7e39eR1852-R1859
Fixes: https://tracker.ceph.com/issues/50928
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com