monitoring:Adding the Ceph MIB #43274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ceph MIB has been created and maintained in a a separate repo: https://github.com/SUSE/prometheus-webhook-snmp This patch brings this MIB into the main ceph repo, so alert changes can target prometheus and potentially SNMP environments within the same PR. Kudos to Volker Theile for creating the MIB. Fixes: https://tracker.ceph.com/issues/52708 Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
votdev
previously requested changes
Sep 28, 2021
epuertat
reviewed
Sep 30, 2021
Comment on lines
+1
to
+11
| CEPH-PROMETHEUS-ALERT-MIB DEFINITIONS ::= BEGIN | ||
|
|
||
| IMPORTS | ||
| MODULE-IDENTITY, OBJECT-TYPE, NOTIFICATION-TYPE, enterprises, TimeTicks | ||
| FROM SNMPv2-SMI | ||
| DisplayString | ||
| FROM SNMPv2-TC | ||
| ; | ||
|
|
||
| ceph OBJECT IDENTIFIER ::= { enterprises 50495 } | ||
| prometheus OBJECT IDENTIFIER ::= { ceph 15 } |
There was a problem hiding this comment.
Have you run this through an MIB validator? I looked for an online one, and it's reporting some errors (maybe they're just false positives):
There was a problem hiding this comment.
I'll take a look. However, @votdev MIB is the best we have at this point. I'd like to get the MIB across and then build on it.
I know the MIB loads and I've been running tests with snmptrapd to verify the integration
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
sebastian-philipp
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ceph MIB has been created and maintained in a a separate repo:
https://github.com/SUSE/prometheus-webhook-snmp
This patch brings this MIB into the main ceph repo, so alert changes can target
prometheus and potentially SNMP environments within the same PR.
Kudos to Volker Theile for creating the MIB.
Fixes: https://tracker.ceph.com/issues/52708
Signed-off-by: Paul Cuzner pcuzner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox