pacific: msgr/async: fix unsafe access in unregister_conn() #43548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were looking at anon_conns and accepting_conns without holding the lock (deleted_lock is not sufficient). Drop this test, and move the decrements: - inc when we add to conns or anon_conns (no changes there) - dec when we remove from deleted_conns (several different paths!) Fixes: https://tracker.ceph.com/issues/49237 Signed-off-by: Sage Weil <sage@newdream.net> (cherry picked from commit d51d80b) Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
tchaikov
approved these changes
Oct 16, 2021
neha-ojha
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent tracker: https://tracker.ceph.com/issues/49237.
backport tracker: https://tracker.ceph.com/issues/50483.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox