radosgw-admin: allow 'bi purge' to delete index if entrypoint doesn't exist #43591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when multisite is enabled, bucket deletion only deletes the bucket's entrypoint, preserving the bucket instance metadata and its index objects in case sync isn't finished these deleted bucket instances show up in |
adamemerson
approved these changes
Oct 19, 2021
|
jenkins test api |
ivancich
approved these changes
Oct 20, 2021
src/rgw/rgw_admin.cc
Outdated
| @@ -1149,7 +1149,7 @@ static int init_bucket(rgw::sal::User* user, | |||
| b.tenant = tenant_name; | |||
| b.name = bucket_name; | |||
| if (!bucket_id.empty()) { | |||
| b.bucket_id = bucket_name + ":" + bucket_id; | |||
| b.bucket_id = bucket_id; | |||
There was a problem hiding this comment.
There is a constructor for rgw_bucket that takes these 3 parameters.
|
jenkins test api |
Fixes: https://tracker.ceph.com/issues/52976 Signed-off-by: Casey Bodley <cbodley@redhat.com>
we may get -ENOENT looking up cur_bucket here. we look up cur_bucket so we can avoid purging the 'current' bucket instance. but if that entrypoint doesn't exist, there is no current instance and that shouldn't prevent us from purging Fixes: https://tracker.ceph.com/issues/52976 Signed-off-by: Casey Bodley <cbodley@redhat.com>
dang
approved these changes
Oct 20, 2021
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two separate fixes:
Fixes: https://tracker.ceph.com/issues/52976
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox