pacific: mgr/dashboard,prometheus: fix handling of server_addr #43631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 157a7b4 corrected the URI published by dashboard/prometheus to use get_mgr_ip() if the address was the wildcard (eg ::). However, the change also affected the cherrypy server.socket_host config value, so the modules could no longer bind to a wildcard. This patch corrects the commit to not affect the cherrypy config. It also further corrects the dashboard URI fix to handle the 0.0.0.0 wildcard case (prometheus already had this behavior). Fixes: 157a7b4 Fixes: http://tracker.ceph.com/issues/52002 Signed-off-by: Scott Shambarger <devel@shambarger.net> (cherry picked from commit de97432)
avanthakkar
requested review from
pereman2 and
aaSharma14
and removed request for
a team
pereman2
approved these changes
Oct 25, 2021
nizamial09
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/52803
backport of #42716
parent tracker: https://tracker.ceph.com/issues/52002
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh