mgr/cephadm: inform users if limit set for data devices is not met

[adk3798]

Signed-off-by: Adam King adking@redhat.com

################
OSDSPEC PREVIEWS
################
NOTE: Did not find enough disks matching filter on host vm-00 to reach data device limit (Found: 4 | Limit: 7)
NOTE: Did not find enough disks matching filter on host vm-01 to reach data device limit (Found: 4 | Limit: 7)
NOTE: Did not find enough disks matching filter on host vm-02 to reach data device limit (Found: 4 | Limit: 7)
+---------+--------------+-------+----------+----+-----+
|SERVICE  |NAME          |HOST   |DATA      |DB  |WAL  |
+---------+--------------+-------+----------+----+-----+
|osd      |osd_spec_hdd  |vm-00  |/dev/vdb  |-   |-    |
|osd      |osd_spec_hdd  |vm-00  |/dev/vdc  |-   |-    |
|osd      |osd_spec_hdd  |vm-00  |/dev/vdd  |-   |-    |
|osd      |osd_spec_hdd  |vm-00  |/dev/vde  |-   |-    |
|osd      |osd_spec_hdd  |vm-01  |/dev/vdb  |-   |-    |
|osd      |osd_spec_hdd  |vm-01  |/dev/vdc  |-   |-    |
|osd      |osd_spec_hdd  |vm-01  |/dev/vdd  |-   |-    |
|osd      |osd_spec_hdd  |vm-01  |/dev/vde  |-   |-    |
|osd      |osd_spec_hdd  |vm-02  |/dev/vdb  |-   |-    |
|osd      |osd_spec_hdd  |vm-02  |/dev/vdc  |-   |-    |
|osd      |osd_spec_hdd  |vm-02  |/dev/vdd  |-   |-    |
|osd      |osd_spec_hdd  |vm-02  |/dev/vde  |-   |-    |
+---------+--------------+-------+----------+----+-----+
[ceph: root@vm-00 /]# cat osd-spec.yaml 
service_id: osd_spec_hdd
placement:
  host_pattern: '*'
data_devices:
  rotational: 1
  limit: 7
  
[ceph: root@vm-00 /]# ceph orch device ls
HOST   PATH      TYPE  DEVICE ID   SIZE  AVAILABLE  REJECT REASONS  
vm-00  /dev/vdb  hdd              53.6G  Yes                        
vm-00  /dev/vdc  hdd              53.6G  Yes                        
vm-00  /dev/vdd  hdd              53.6G  Yes                        
vm-00  /dev/vde  hdd              53.6G  Yes                        
vm-01  /dev/vdb  hdd              53.6G  Yes                        
vm-01  /dev/vdc  hdd              53.6G  Yes                        
vm-01  /dev/vdd  hdd              53.6G  Yes                        
vm-01  /dev/vde  hdd              53.6G  Yes                        
vm-02  /dev/vdb  hdd              53.6G  Yes                        
vm-02  /dev/vdc  hdd              53.6G  Yes                        
vm-02  /dev/vdd  hdd              53.6G  Yes                        
vm-02  /dev/vde  hdd              53.6G  Yes        

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[sebastian-philipp]

is there a way we can verify this is a test?

[adk3798]

is there a way we can verify this is a test?

Added a unit test for the changes in generate_preview

[sebastian-philipp]

jenkins test api

[adk3798]

http://pulpito.front.sepia.ceph.com/adking-2021-10-30_00:36:30-rados:cephadm-wip-adk-testing-2021-10-29-1557-distro-basic-smithi/

1 Failure Tracked by https://tracker.ceph.com/issues/49287