pacific: rgw: add abstraction for ops log destination and add file logger #43740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfsnyder
force-pushed
the
wip-53091-pacific
branch
3 times, most recently
from
cba5556
to
83122ed
Compare
cfsnyder
force-pushed
the
wip-53091-pacific
branch
3 times, most recently
from
ef2fd28
to
5377fc9
Compare
|
please make sure the commit from #43751 gets cherry-picked here after it merges to master |
Adds an OpsLogSink abstraction for ops log destinations. Also implements this abstraction for a file logger since it's easier to use files vs. sockets with containers. Fixes: https://tracker.ceph.com/issues/48752 Signed-off-by: Cory Snyder <csnyder@iland.com> (cherry picked from commit c4c9f39) Conflicts: src/common/options/rgw.yaml.in src/rgw/librgw.cc src/rgw/rgw_log.cc src/rgw/rgw_log.h src/rgw/rgw_lua_request.cc src/rgw/rgw_process.cc Cherry-pick notes: - Conflict due to change in configuration option specification between Pacific and master - Conflicts due to renaming RGWRados to rgw::sal::Store - Conflicts due to whitespace changes
can't use ceph::mutex locks with std::condition_variable::wait() in debug builds. use the ceph::condition_variable wrapper instead Signed-off-by: Casey Bodley <cbodley@redhat.com>
cfsnyder
force-pushed
the
wip-53091-pacific
branch
from
5377fc9
to
205f203
Compare
|
jenkins build docs |
cbodley
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/53091
backport of #43329
parent tracker: https://tracker.ceph.com/issues/48752
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh