Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: include mfa_ids in rgw user-details section #43845

Merged
merged 1 commit into from Nov 10, 2021
Merged

mgr/dashboard: include mfa_ids in rgw user-details section #43845

merged 1 commit into from Nov 10, 2021

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Nov 8, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/53193
Signed-off-by: Avan Thakkar athakkar@redhat.com

Introducing mfa_ids in user details section.
Screenshot from 2021-11-09 21-53-59

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@avanthakkar avanthakkar added this to In progress in Dashboard via automation Nov 8, 2021
@github-actions github-actions bot added the pybind label Nov 8, 2021
@avanthakkar avanthakkar force-pushed the add-mfa-ids-in-rgw-user-details branch from b21f324 to 3e406b7 Compare November 9, 2021 06:28
@avanthakkar avanthakkar force-pushed the add-mfa-ids-in-rgw-user-details branch from 3e406b7 to 22325fe Compare November 9, 2021 12:58
@avanthakkar
Copy link
Contributor Author

jenkins test api

@avanthakkar avanthakkar marked this pull request as ready for review November 10, 2021 06:29
@avanthakkar avanthakkar requested a review from a team as a code owner November 10, 2021 06:29
@avanthakkar avanthakkar requested review from pereman2 and removed request for a team November 10, 2021 06:29
@epuertat epuertat moved this from In progress to Review in progress in Dashboard Nov 10, 2021
epuertat
epuertat approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @avanthakkar! Just 2 minor improvements/cleanups.

...ind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-details/rgw-user-details.component.html Outdated Show resolved Hide resolved
...ind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-details/rgw-user-details.component.html Outdated Show resolved Hide resolved
Dashboard automation moved this from Review in progress to Reviewer approved Nov 10, 2021
@avanthakkar avanthakkar force-pushed the add-mfa-ids-in-rgw-user-details branch from 22325fe to 745c4c9 Compare November 10, 2021 10:14
@avanthakkar
mgr/dashboard: include mfa_ids in rgw user-details section
6a2234c 
Fixes: https://tracker.ceph.com/issues/53193
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Introducing mfa_ids in user details section.
@avanthakkar avanthakkar force-pushed the add-mfa-ids-in-rgw-user-details branch from 745c4c9 to 6a2234c Compare November 10, 2021 11:04
@avanthakkar
Copy link
Contributor Author

jenkins test make check

@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard Nov 10, 2021
@avanthakkar avanthakkar added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Nov 10, 2021
Dashboard automation moved this from Ready-to-merge to Reviewer approved Nov 10, 2021
@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard Nov 10, 2021
Dashboard automation moved this from Ready-to-merge to Reviewer approved Nov 10, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Nov 10, 2021
@epuertat epuertat merged commit fe74cd8 into ceph:master Nov 10, 2021
9 checks passed
Dashboard automation moved this from Ready-to-merge to Done Nov 10, 2021
@epuertat epuertat deleted the add-mfa-ids-in-rgw-user-details branch November 10, 2021 20:52
@avanthakkar avanthakkar mentioned this pull request Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@pereman2 pereman2 pereman2 approved these changes

@epuertat epuertat epuertat approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

Assignees
No one assigned
Labels
dashboard feature needs-review pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@avanthakkar @alfonsomthd @pereman2 @epuertat @nizamial09