Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind/mgr/pg_autoscale: revert to default profile scale-up #43999

Merged
merged 1 commit into from Nov 20, 2021
Merged

pybind/mgr/pg_autoscale: revert to default profile scale-up #43999

merged 1 commit into from Nov 20, 2021

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Nov 18, 2021 •
edited by neha-ojha

pg_autoscale module will now start out all the pools
with a scale-up profile by default.

Added tests in workunits/mon/pg_autoscaler.sh
to evaluate if the default pool creation is
a scale-up profile

Updated documentation and release notes to
reflect the change in the default behavior
of the pg_autoscale profile.

Fixes: https://tracker.ceph.com/issues/53309

Signed-off-by: Kamoltat ksirivad@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
  • Teuthology
    • Completed teuthology run
    • No teuthology test necessary (e.g., documentation)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kamoltat kamoltat self-assigned this Nov 18, 2021
@kamoltat kamoltat force-pushed the wip-autoscale-profile-scale-up-default branch 2 times, most recently from 10670b6 to c82fa6a Compare November 18, 2021 15:32
@github-actions github-actions bot added the tests label Nov 18, 2021
@kamoltat
Copy link
Member Author

kamoltat commented Nov 18, 2021 •
edited

https://pulpito.ceph.com/ksirivad-2021-11-18_19:50:17-rados:singleton:all:pg-autoscaler.yaml-wip-autoscale-profile-scale-up-default-distro-basic-smithi/6512431/

test failed because grep -oe grabs all matches scale-up should have done grep -E -o -m 1 to grab only 1 match

@kamoltat kamoltat force-pushed the wip-autoscale-profile-scale-up-default branch from c82fa6a to b733a24 Compare November 18, 2021 21:50
@kamoltat kamoltat mentioned this pull request Nov 18, 2021
Closed
3 tasks
@kamoltat
Copy link
Member Author

Test:
https://pulpito.ceph.com/ksirivad-2021-11-18_21:54:49-rados:singleton:all:pg-autoscaler.yaml-wip-autoscale-profile-scale-up-default-distro-basic-smithi/

@neha-ojha
Copy link
Member

Test: https://pulpito.ceph.com/ksirivad-2021-11-18_21:54:49-rados:singleton:all:pg-autoscaler.yaml-wip-autoscale-profile-scale-up-default-distro-basic-smithi/

This is still failing with

2021-11-18T22:19:41.086 INFO:tasks.workunit.client.0.smithi058.stderr:+ echo 'Error: a PROFILE is scale-down'
2021-11-18T22:19:41.087 INFO:tasks.workunit.client.0.smithi058.stdout:Error: a PROFILE is scale-down
2021-11-18T22:19:41.087 DEBUG:teuthology.orchestra.run:got remote process result: 1

@kamoltat kamoltat force-pushed the wip-autoscale-profile-scale-up-default branch 2 times, most recently from c93452f to 05ad655 Compare November 19, 2021 15:09
@kamoltat
Copy link
Member Author

1/1 passed
https://pulpito.ceph.com/ksirivad-2021-11-19_15:13:16-rados:singleton:all:pg-autoscaler.yaml-wip-autoscale-profile-scale-up-default-distro-basic-smithi/

@neha-ojha
Copy link
Member

jenkins test make check

@kamoltat
pybind/mgr/pg_autoscale: revert to default profile scale-up
a9f9f7b 
pg_autoscale module will now start out all the pools
with a scale-up profile by default.

Added tests in workunits/mon/pg_autoscaler.sh
to evaluate if the default pool creation is
a scale-up profile

Updated documentation and release notes to
reflect the change in the default behavior
of the pg_autoscale profile.

Fixes: https://tracker.ceph.com/issues/53309

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-autoscale-profile-scale-up-default branch from 05ad655 to a9f9f7b Compare November 19, 2021 18:56
neha-ojha
neha-ojha approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also run this through a broader rados suite

@neha-ojha
Copy link
Member

Being tested at: https://pulpito.ceph.com/ksirivad-2021-11-19_19:14:07-rados-wip-autoscale-profile-scale-up-default-distro-basic-smithi/

@kamoltat kamoltat mentioned this pull request Nov 19, 2021
Merged
15 tasks
@neha-ojha
Copy link
Member

Being tested at: https://pulpito.ceph.com/ksirivad-2021-11-19_19:14:07-rados-wip-autoscale-profile-scale-up-default-distro-basic-smithi/

no relates failures, unrelated failures tracked in https://pad.ceph.com/p/rado_suite_test_laura_junior

@neha-ojha neha-ojha merged commit 0f9ed11 into ceph:master Nov 20, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

Assignees

@kamoltat kamoltat

Labels
core documentation mgr mon needs-qa pybind tests
Projects
None yet
Milestone
No milestone
2 participants
@kamoltat @neha-ojha