osd/PeeringState: separate history's pruub from pg's #44015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(pruub = prior_readable_until_ub [upper bound]) During peering, a primary may conclude that it does not need to wait for the prior interval(s)' read lease because it will query all such osds. However, it is dangerous to reflect that local inference about future peering effects in the info.history, which is freely shared with other OSDs. For example, if the primary cleared the history pruub, shared it, and then failed, the next primary may conclude that it does not need to wait for the lease to expire. Instead, track the pruub in the conventional way. Only at the end of peering do we clear it (if there are no prior_interval_down_osds) before ending our final activate infos out, when we have already talked to the peer osds and they know the prior interval has finished. Fixes: https://tracker.ceph.com/issues/53326 Signed-off-by: Sage Weil <sage@newdream.net>
athanatos
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(pruub = prior_readable_until_ub [upper bound])
During peering, a primary may conclude that it does not need to wait for
the prior interval(s)' read lease because it will query all such osds.
However, it is dangerous to reflect that local inference about future
peering effects in the info.history, which is freely shared with other
OSDs. For example, if the primary cleared the history pruub, shared it,
and then failed, the next primary may conclude that it does not need to
wait for the lease to expire.
Instead, track the pruub in the conventional way. Only at the end of
peering do we clear it (if there are no prior_interval_down_osds) before
ending our final activate infos out, when we have already talked to the
peer osds and they know the prior interval has finished.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox