rgw/beast: add max_header_size option with 16k default, up from 4k #44029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in f13c691, we switched to a static 64k parse buffer. this gives us a lot of room to raise the header_limit above 4k adds a "max_header_size" frontend option with default 16k and maximum value equal to the 64k parse buffer size Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley
force-pushed
the
wip-rgw-beast-header-limit
branch
from
62cfd83
to
d9f4940
Compare
|
jenkins render docs |
| @@ -533,15 +533,32 @@ int AsioFrontend::init() | |||
| // Setting global timeout | |||
| auto timeout = config.find("request_timeout_ms"); | |||
| if (timeout != config.end()) { | |||
| auto timeout_number = ceph::parse<uint64_t>(timeout->second.data()); | |||
There was a problem hiding this comment.
How did timeout->second's type change?
There was a problem hiding this comment.
this was a just a cosmetic cleanup. timeout->second is a std::string, and ceph::parse() takes std::string_view. std::string_view is happy to convert from std::string, so the extra conversion to char* data() wasn't necessary
There was a problem hiding this comment.
ah, ok; thanks for explaining
|
jenkins render docs |
mkogan1
approved these changes
Nov 22, 2021
|
Created an upstream tracker - https://tracker.ceph.com/issues/53546 for backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in f13c691, we switched to a static 64k parse buffer. this gives us a lot of room to raise the header_limit above 4k
adds a "max_header_size" frontend option with default 16k and maximum value equal to the 64k parse buffer size
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox