New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: cancel_pull: requeue waiters #4415

Merged
1 commit merged into from May 15, 2015

Conversation

Projects
None yet
3 participants
@xinxinsh
Member

xinxinsh commented Apr 21, 2015

ReplicatedPG::cancel_pull: requeue waiters as well
If we are in recovery_wait, we might not recover that object as part of
recover_primary for some time.  Worse, if we are waiting on a backfill
which is blocked waiting on a copy_from on the missing object in
question, it can become a dead lock.

Fixes: 11244
Backport: firefly
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 0b2e272)

@ghost ghost added bug fix core labels Apr 21, 2015

@ghost ghost assigned xinxinsh Apr 21, 2015

@ghost ghost added this to the firefly milestone Apr 21, 2015

@ghost

This comment has been minimized.

ghost commented May 15, 2015

@athanatos does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11090#rados for details ). There was only one failure described at http://tracker.ceph.com/issues/11142#note-5

ghost pushed a commit that referenced this pull request May 15, 2015

Loic Dachary
Merge pull request #4415 from xinxinsh/wip-11244-firefly
cancel_pull: requeue waiters

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit 114f2e9 into ceph:firefly May 15, 2015

@ghost ghost changed the title from cancel_pull: requeue waiters to osd: cancel_pull: requeue waiters Jul 14, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment