Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: cleanup (and minor optimization) of GIL handling #44207

Merged
merged 2 commits into from Dec 8, 2021
Merged

mgr: cleanup (and minor optimization) of GIL handling #44207

merged 2 commits into from Dec 8, 2021

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Dec 3, 2021 •
edited

  • avoid unnecessary GIL lock/unlock cycles by avoiding overuse of RIAA helpers.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
  • Teuthology
    • Completed teuthology run
    • No teuthology test necessary (e.g., documentation)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@liewegas
mgr/ActivePyModules: push without_gil_t down into blocks
1da9885 
Some of these don't need to drop the GIL.  Push down into each block as
needed.

Signed-off-by: Sage Weil <sage@newdream.net>
@liewegas
mgr/ActivePyModule: avoid with_gil where possible
6469a9a 
The common pattern of

 without_gil_t no_gil;
 ...
 with_gil_t with_gil(no_gil);
 ...

is that when the stack unwindws, ~with_gil_t() will drop the GIL and then
~without_gil_t() will retake it again, adding a completely unnecessary
unlock/lock cycle.

Instead, do

 no_gil.acquire_gil();

when we are ready to retake the GIL.  ~without_gil_t() will then be a
no-op.

Signed-off-by: Sage Weil <sage@newdream.net>
@liewegas liewegas merged commit 60e0ea0 into ceph:master Dec 8, 2021
@neha-ojha neha-ojha mentioned this pull request Feb 2, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

Assignees
No one assigned
Labels
core mgr needs-qa performance wip-sage2-testing
Projects
None yet
Milestone
No milestone
2 participants
@liewegas @tchaikov