Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/progress: avoid dumping all pg stats for progress updates #44208

Merged
merged 1 commit into from Dec 16, 2021
Merged

mgr/progress: avoid dumping all pg stats for progress updates #44208

merged 1 commit into from Dec 16, 2021

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Dec 3, 2021 •
edited

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Performance improvement / cleanup (no ticket needed)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@liewegas
mgr/progress: avoid inefficient dump of all pg stats
f5973cc 
We only use a handful of fields, and the pg dump includes a gazillion
fields that we waste CPU copying to python-land.  This tends to lead to
long ClusterState::lock hold times, leading to long ms_dispatch delays
and generally gumming up the works.

Instead, create a new "pg_progress" item that dumps only the fields that
mgr/progress needs.

Fixes: https://tracker.ceph.com/issues/53475
Signed-off-by: Sage Weil <sage@newdream.net>
neha-ojha
neha-ojha approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @kamoltat can you also please take a look

kamoltat
kamoltat approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this, just need a clean run through rados:mgr tasks/progress

@liewegas liewegas merged commit 7b7686d into ceph:master Dec 16, 2021
@cfsnyder cfsnyder mentioned this pull request Jan 11, 2022
Closed
@kamoltat kamoltat mentioned this pull request Jan 19, 2022
Merged
14 tasks
@neha-ojha neha-ojha mentioned this pull request Feb 2, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@kamoltat kamoltat kamoltat approved these changes

@pereman2 pereman2 Awaiting requested review from pereman2

@tchaikov tchaikov Awaiting requested review from tchaikov

Assignees
No one assigned
Labels
core mgr mon needs-qa pybind wip-sage2-testing wip-sage3-testing
Projects
None yet
Milestone
No milestone
3 participants
@liewegas @neha-ojha @kamoltat