Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: allow miscellaneous container args at service level #44459

Merged
merged 1 commit into from Jan 25, 2022

Conversation

adk3798
Copy link
Contributor

@adk3798 adk3798 commented Jan 5, 2022

Signed-off-by: Adam King adking@redhat.com

Fixes: https://tracker.ceph.com/issues/51566

E.g. applying a spec like

service_type: mon
service_name: mon
placement:
  count: 5
extra_container_args:
  - "--cpus=2"
  - "--quiet"

would get you all the mons would deployed with --cpus=2 --quiet

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@adk3798
Copy link
Contributor Author

adk3798 commented Jan 5, 2022

Changed from dict to list of str for extra args, fixed unit tests, added new unit test for this change

src/cephadm/cephadm Outdated Show resolved Hide resolved
src/cephadm/cephadm Outdated Show resolved Hide resolved
@sebastian-philipp
Copy link
Contributor

ping @adk3798 ?

@adk3798 adk3798 force-pushed the misc-args branch 2 times, most recently from 2f53cca to 8e98842 Compare January 18, 2022 20:05
@adk3798 adk3798 requested a review from a team as a code owner January 18, 2022 20:05
@adk3798
Copy link
Contributor Author

adk3798 commented Jan 18, 2022

ping @adk3798 ?

review comments should be addressed now. This is ready for a new review and qa if no concerns

@sebastian-philipp sebastian-philipp added wip-swagner-testing My Teuthology tests and removed needs-review labels Jan 19, 2022
@adk3798
Copy link
Contributor Author

adk3798 commented Jan 19, 2022

jenkins test make check

3 similar comments
@adk3798
Copy link
Contributor Author

adk3798 commented Jan 20, 2022

jenkins test make check

@adk3798
Copy link
Contributor Author

adk3798 commented Jan 24, 2022

jenkins test make check

@adk3798
Copy link
Contributor Author

adk3798 commented Jan 25, 2022

jenkins test make check

@sebastian-philipp sebastian-philipp merged commit aa875e7 into ceph:master Jan 25, 2022
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants