New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: PG::actingset should be used when checking the number of acting OSDs for... #4453

Merged
merged 1 commit into from Apr 27, 2015

Conversation

Projects
None yet
4 participants
@dzafman
Member

dzafman commented Apr 23, 2015

... a given PG.

Signed-off-by: Guang Yang yguang@yahoo-inc.com

(cherry picked from commit 19be358)

Conflicts:
src/osd/PG.cc PG::get_backfill_priority() doesn't exist in firefly
Variation in code related to no "undersized" state in firefly

Fixes: #11454

PG::actingset should be used when checking the number of acting OSDs …
…for a given PG.

Signed-off-by: Guang Yang <yguang@yahoo-inc.com>

(cherry picked from commit 19be358)

Conflicts:
	src/osd/PG.cc	PG::get_backfill_priority() doesn't exist in firefly
			Variation in code related to no "undersized" state in firefly

Fixes: #11454

@liewegas liewegas added this to the firefly milestone Apr 23, 2015

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 23, 2015

lgtm

@dzafman

This comment has been minimized.

Member

dzafman commented Apr 24, 2015

I tested this manually. Created an EC pool with k=2 m=1 in a 3 osd cluster. Killed one osd and marked it out.

firefly:
active+clean and active+remapped (an OSD has 2 shards [1,2,1])

wip-11454:
active+clean+degraded and active+remapped (an OSD has 2 shards [1,2,1])

@dzafman dzafman removed the needs-qa label Apr 24, 2015

dzafman added a commit that referenced this pull request Apr 27, 2015

Merge pull request #4453 from ceph/wip-11454
PG::actingset should be used when checking the number of acting OSDs for...

Reviewed-by: Sage Weil <sage@redhat.com>

@dzafman dzafman merged commit da75978 into firefly Apr 27, 2015

@dzafman dzafman deleted the wip-11454 branch Apr 27, 2015

@ghost ghost changed the title from PG::actingset should be used when checking the number of acting OSDs for... to osd: PG::actingset should be used when checking the number of acting OSDs for... Jul 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment