Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: mon: prevent new sessions during shutdown #44543

Merged
merged 1 commit into from Feb 16, 2022
Merged

pacific: mon: prevent new sessions during shutdown #44543

merged 1 commit into from Feb 16, 2022

Conversation

cfsnyder
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/53659

backport of #44337
parent tracker: https://tracker.ceph.com/issues/39150

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@liewegas @cfsnyder
mon: prevent new sessions during shutdown
6b441f6 
From shutdown() we set STATE_SHUTDOWN and then call remove_all_sessions().
ms_handle_accept() is the only caller of add_session, so verifying that
we aren't shutting down (while under the session_map_lock) is sufficient
to prevent any new sessions from being added.

Fixes: https://tracker.ceph.com/issues/39150
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit c98b268)
@cfsnyder cfsnyder added this to the pacific milestone Jan 11, 2022
@cfsnyder cfsnyder added the core label Jan 11, 2022
@github-actions github-actions bot added the mon label Jan 11, 2022
@badone
Copy link
Contributor

badone commented Feb 15, 2022

@yuriw Any update on testing?

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-02-09_22:52:18-rados-wip-yuri5-testing-2022-02-09-1322-pacific-distro-default-smithi/
http://pulpito.front.sepia.ceph.com/yuriw-2022-02-08_17:00:23-rados-wip-yuri5-testing-2022-02-08-0733-pacific-distro-default-smithi/

Failures, unrelated:
https://tracker.ceph.com/issues/53501
https://tracker.ceph.com/issues/51234
https://tracker.ceph.com/issues/52124
https://tracker.ceph.com/issues/48997
https://tracker.ceph.com/issues/45702
https://tracker.ceph.com/issues/50222
https://tracker.ceph.com/issues/51904

Details:
Bug_#53501: Exception when running 'rook' task. - Ceph - Orchestrator
Bug_#51234: LibRadosService.StatusFormat failed, Expected: (0) != (retry), actual: 0 vs 0 - Ceph - RADOS
Bug_#52124: Invalid read of size 8 in handle_recovery_delete() - Ceph - RADOS
BUg_#48997: rados/singleton/all/recovery-preemption: defer backfill|defer recovery not found in logs - Ceph - RADOS
Bug_#45702: PGLog::read_log_and_missing: ceph_assert(miter == missing.get_items().end() || (miter->second.need == i->version && miter->second.have == eversion_t())) - Ceph - RADOS
Bug_#50222: osd: 5.2s0 deep-scrub : stat mismatch - Ceph - RADOS
Bug_#51904: AssertionError: wait_for_clean: failed before timeout expired due to down PGs - Ceph - RADOS

@badone badone removed the needs-qa label Feb 15, 2022
@badone badone merged commit 8590d0f into ceph:pacific Feb 16, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
core mon wip-yuri5-testing
Projects
None yet
Milestone
pacific
6 participants
@cfsnyder @badone @ljflores @neha-ojha @yuriw @liewegas