pacific: python-common: improve OSD spec error messages #44626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
mgfritch
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Do we care to backport #42727 and it's dependent PRs before this PR to avoid losing track of these lines?
ceph/src/python-common/ceph/deployment/drive_group.py
Lines 336 to 343 in 24aab16
otherwise, lgtm!
|
I personally don't really care about raw osds in pacific. Do you? |
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 38b52f7)
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit b91f818) Conflicts: src/python-common/ceph/deployment/drive_group.py
Fixes: https://tracker.ceph.com/issues/47401 Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 4142c52) Conflicts: src/python-common/ceph/deployment/drive_group.py
Fixes: https://tracker.ceph.com/issues/50685 Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 74f29b9)
Cause it never actually worked as expected. Remove duplicated service_id check, cause it's already verified by parent method. Fixes: https://tracker.ceph.com/issues/46253 Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 8b567e1) Conflicts: src/python-common/ceph/deployment/service_spec.py
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 3118604)
Adjust HostSpec interface to ServiceSpec Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 7c6d922) Conflicts: src/python-common/ceph/deployment/service_spec.py
unfortunately `ceph orch ls` may return invalid OSD specs for OSDs not associated to and specs. Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 3f38583) Conflicts: src/pybind/mgr/orchestrator/module.py
Signed-off-by: Sebastian Wagner <sewagner@redhat.com> (cherry picked from commit 1c40ca1)
sebastian-philipp
force-pushed
the
pacific-backport-42905
branch
from
4d44460
to
030564e
Compare
|
changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42905