Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: mgr/cephadm: Fix count for OSDs with OSD specs #44629

Merged
merged 1 commit into from Feb 23, 2022
Merged

pacific: mgr/cephadm: Fix count for OSDs with OSD specs #44629

merged 1 commit into from Feb 23, 2022

Conversation

sebastian-philipp
Copy link
Contributor

Backport of #44367

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner January 18, 2022 11:01
@sebastian-philipp sebastian-philipp added this to the octopus milestone Jan 18, 2022
@github-actions github-actions bot modified the milestones: octopus, pacific Jan 18, 2022
adk3798
adk3798 requested changes Jan 18, 2022
View reviewed changes
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@sebastian-philipp
Copy link
Contributor Author

BLOCKED. needs #44626

FAILED cephadm/tests/test_cephadm.py::TestCephadm::test_osd_count - ceph.deployment.hostspec.SpecValidationError: Cannot add Service: id required

@sebastian-philipp
Copy link
Contributor Author

jenkins test make check

@sebastian-philipp @adk3798
mgr/cephadm: Fix count for OSDs with OSD specs
8cdf526 
osd counting is special

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Conflicts:
	src/pybind/mgr/cephadm/module.py
	src/pybind/mgr/cephadm/tests/test_cephadm.py
@adk3798
Copy link
Contributor

adk3798 commented Feb 22, 2022

http://pulpito.front.sepia.ceph.com/adking-2022-02-22_01:38:48-orch:cephadm-wip-adk2-testing-2022-02-21-1650-pacific-distro-basic-smithi/

Failures Tracked by
https://tracker.ceph.com/issues/54304
https://tracker.ceph.com/issues/54273
https://tracker.ceph.com/issues/53939

@adk3798
Copy link
Contributor

adk3798 commented Feb 22, 2022

jenkins test api

1 similar comment
@adk3798
Copy link
Contributor

adk3798 commented Feb 23, 2022

jenkins test api

@adk3798 adk3798 merged commit 3fe9f4d into ceph:pacific Feb 23, 2022
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adk3798 adk3798 adk3798 approved these changes

Assignees
No one assigned
Labels
cephadm pybind wip-adk2-testing
Projects
None yet
Milestone
pacific
2 participants
@sebastian-philipp @adk3798