Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: osd: PeeringState: fix selection order in calc_replicated_acting_stretch #44664

Merged
merged 1 commit into from Mar 25, 2022
Merged

pacific: osd: PeeringState: fix selection order in calc_replicated_acting_stretch #44664

merged 1 commit into from Mar 25, 2022

Conversation

gregsfortytwo
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/53933

backport of #44518
parent tracker: https://tracker.ceph.com/issues/53824

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@gregsfortytwo
osd: PeeringState: fix selection order in calc_replicated_acting_stretch
7f99d89 
We were previously mis-ordering these to *de*prioritize the existing acting set. That is bad!

We generate OSD candidates from the acting set and strays, and push
them into the candidates list as a tuple of <<!in_acting,pg_info.last_update>,osd_id>.

Then we sort the list. Then we go through the list from front to back and
push_back entries into the appropriate ancestor lists.

And then we pop_back() off the lists to select the acting set.
Which of course turns our nice careful order backwards! So don't do that.

Fixes: https://tracker.ceph.com/issues/53824

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit 0af5eb6)
@gregsfortytwo gregsfortytwo added this to the pacific milestone Jan 19, 2022
@amathuria
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-03-23_14:51:02-rados-wip-yuri4-testing-2022-03-21-1648-pacific-distro-default-smithi/

Unrelated failures tracked in:

https://tracker.ceph.com/issues/54071 - rados/cephadm/osds: Invalid command: missing required parameter hostname()
https://tracker.ceph.com/issues/53501 - Exception when running 'rook' task.
https://tracker.ceph.com/issues/53939 - ceph-nfs-upgrade, pacific: Upgrade Paused due to UPGRADE_REDEPLOY_DAEMON: Upgrading daemon osd.0 on host smithi103 failed
https://tracker.ceph.com/issues/50893 - osd/PrimaryLogPG.cc: FAILED ceph_assert(attrs || !recovery_state.get_pg_log().get_missing().is_missing(soid) || (it_objects != recovery_state.get_pg_log().get_log().objects.end() && it_objects->second->op == pg_log_entry_t::LOST_REVERT))
https://tracker.ceph.com/issues/54406 - cephadm/mgr-nfs-upgrade: cluster [WRN] overall HEALTH_WARN no active mgr

@yuriw yuriw merged commit 993d9e2 into ceph:pacific Mar 25, 2022
6 checks passed
@gregsfortytwo gregsfortytwo deleted the wip-53933-pacific branch May 24, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
core needs-qa wip-yuri4-testing
Projects
None yet
Milestone
pacific
4 participants
@gregsfortytwo @amathuria @neha-ojha @yuriw