Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: CopyObject works with x-amz-copy-source-if-* headers #44678

Merged
merged 1 commit into from Feb 8, 2022
Merged

rgw: CopyObject works with x-amz-copy-source-if-* headers #44678

merged 1 commit into from Feb 8, 2022

Conversation

kipdoudou
Copy link

@kipdoudou kipdoudou commented Jan 20, 2022

CopyObject api support condition headers, eg x-amz-copy-source-if-match, while radosgw miss out the 'source' keyword

Fixes: https://tracker.ceph.com/issues/53945

Signed-off-by: Wang Hao wanghao72@baidu.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the rgw label Jan 20, 2022
@kipdoudou
Copy link
Author

@cbodley please review, thx

Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok; i wonder if we have s3test cases for these headers - a qa run should tell us 👍

@cbodley
Copy link
Contributor

cbodley commented Feb 3, 2022

@kipdoudou could you please update your commit message to fix the Signed-off-by: line? the CI check is failing because it expects <>'s in Signed-off-by: Wang Hao <wanghao72@baidu.com>

@cbodley
Copy link
Contributor

cbodley commented Feb 3, 2022

jenkins test make check

@kipdoudou kipdoudou closed this Feb 4, 2022
@kipdoudou kipdoudou reopened this Feb 4, 2022
@cbodley
Copy link
Contributor

cbodley commented Feb 4, 2022

@kipdoudou i'm afraid the Merge commits here will also prevent us from accepting this PR. can you please rebase this on top of ceph's master branch and squash this back into a single commit?

CopyObject api support condition headers, eg x-amz-copy-source-if-match, while radosgw miss out the 'source' keyword
Fixes: https://tracker.ceph.com/issues/53945

Signed-off-by: Wang Hao <wanghao72@baidu.com>
@kipdoudou
Copy link
Author

@kipdoudou i'm afraid the Merge commits here will also prevent us from accepting this PR. can you please rebase this on top of ceph's master branch and squash this back into a single commit?

yeah, of course. My git env has some problems yesterday, just fix it now. I recommit again, please review again, tkx @cbodley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants